]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
btrfs: use proper endianness accessors for super_copy
authorAnand Jain <anand.jain@oracle.com>
Thu, 22 Feb 2018 13:58:42 +0000 (21:58 +0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 15 Mar 2018 13:27:40 +0000 (08:27 -0500)
commit89a855ae744dd896523f21dba09b55d30bb5b9b2
treef0e5ee78e44d52769af3832ef32e4a2677d69525
parent94899a7407d5bbdb2dfa0f105549a7a52a7cacc5
btrfs: use proper endianness accessors for super_copy

BugLink: http://bugs.launchpad.net/bugs/1755179
commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream.

The fs_info::super_copy is a byte copy of the on-disk structure and all
members must use the accessor macros/functions to obtain the right
value.  This was missing in update_super_roots and in sysfs readers.

Moving between opposite endianness hosts will report bogus numbers in
sysfs, and mount may fail as the root will not be restored correctly. If
the filesystem is always used on a same endian host, this will not be a
problem.

Fix this by using the btrfs_set_super...() functions to set
fs_info::super_copy values, and for the sysfs, use the cached
fs_info::nodesize/sectorsize values.

CC: stable@vger.kernel.org
Fixes: df93589a17378 ("btrfs: export more from FS_INFO to sysfs")
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
fs/btrfs/sysfs.c
fs/btrfs/transaction.c