]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mac80211: track only QoS data frames for admission control
authorJohannes Berg <johannes.berg@intel.com>
Mon, 22 Nov 2021 11:47:40 +0000 (12:47 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:49:24 +0000 (09:49 +0100)
commit8a0a71d99a3c2d4af9672f94e768e5e97cb1ab99
tree71e0366f77962b939cbe88325d64d9382526e703
parentf6a0a090c37b31cbbcfeaa68d1e54b6fc37d0a48
mac80211: track only QoS data frames for admission control

BugLink: https://bugs.launchpad.net/bugs/1956302
[ Upstream commit d5e568c3a4ec2ddd23e7dc5ad5b0c64e4f22981a ]

For admission control, obviously all of that only works for
QoS data frames, otherwise we cannot even access the QoS
field in the header.

Syzbot reported (see below) an uninitialized value here due
to a status of a non-QoS nullfunc packet, which isn't even
long enough to contain the QoS header.

Fix this to only do anything for QoS data packets.

Reported-by: syzbot+614e82b88a1a4973e534@syzkaller.appspotmail.com
Fixes: 02219b3abca5 ("mac80211: add WMM admission control support")
Link: https://lore.kernel.org/r/20211122124737.dad29e65902a.Ieb04587afacb27c14e0de93ec1bfbefb238cc2a0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
net/mac80211/mlme.c