]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: ethernet: aquantia: Handle error cleanup of start on open
authorNathan Rossi <nathan.rossi@digi.com>
Thu, 11 Feb 2021 05:17:57 +0000 (05:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Feb 2021 22:38:06 +0000 (14:38 -0800)
commit8a28af7a3e85ddf358f8c41e401a33002f7a9587
treec37dfb143c09cfaab89b48626442102ae1a175e0
parentb1f19639db8be0e692865758e134d0e8e82212b8
net: ethernet: aquantia: Handle error cleanup of start on open

The aq_nic_start function can fail in a variety of cases which leaves
the device in broken state.

An example case where the start function fails is the
request_threaded_irq which can be interrupted, resulting in a EINTR
result. This can be manually triggered by bringing the link up (e.g. ip
link set up) and triggering a SIGINT on the initiating process (e.g.
Ctrl+C). This would put the device into a half configured state.
Subsequently bringing the link up again would cause the napi_enable to
BUG.

In order to correctly clean up the failed attempt to start a device call
aq_nic_stop.

Signed-off-by: Nathan Rossi <nathan.rossi@digi.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_main.c