]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net/mlx5e: RX, Fix wrong early return in receive queue poll
authorTariq Toukan <tariqt@mellanox.com>
Sun, 2 Dec 2018 13:45:53 +0000 (15:45 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit8a3685c42a2482efe9c31344fde890d612b92f32
treed647e4ce19f30a4866ce154049e5efd6766be009
parent088b456cc3038db7c4305fa15c40a9962c8f71cb
net/mlx5e: RX, Fix wrong early return in receive queue poll

BugLink: https://bugs.launchpad.net/bugs/1837257
[ Upstream commit bfc698254ba97b3e3e4ebbfae0ffa1f7e2fa0717 ]

When the completion queue of the RQ is empty, do not immediately return.
If left-over decompressed CQEs (from the previous cycle) were processed,
need to go to the finalization part of the poll function.

Bug exists only when CQE compression is turned ON.

This solves the following issue:
mlx5_core 0000:82:00.1: mlx5_eq_int:544:(pid 0): CQ error on CQN 0xc08, syndrome 0x1
mlx5_core 0000:82:00.1 p4p2: mlx5e_cq_error_event: cqn=0x000c08 event=0x04

Fixes: 4b7dfc992514 ("net/mlx5e: Early-return on empty completion queues")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c