]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred
authorXiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Tue, 7 Jun 2022 08:32:30 +0000 (16:32 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Jun 2022 17:18:10 +0000 (10:18 -0700)
commit8a4d480702b71184fabcf379b80bf7539716752e
treecc17333b3c902d8f6aef18faa57b74b146f814a8
parente44c8f4080ca264b5aac3183a321538662b0950b
nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred

Similar to the handling of play_deferred in commit 19cfe912c37b
("Bluetooth: btusb: Fix memory leak in play_deferred"), we thought
a patch might be needed here as well.

Currently usb_submit_urb is called directly to submit deferred tx
urbs after unanchor them.

So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb
and cause memory leak.

Put those urbs in tx_anchor to avoid the leak, and also fix the error
handling.

Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220607083230.6182-1-xiaohuizhang@ruc.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/nfcmrvl/usb.c