]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
pwm: vt8500: Register write busy test performed incorrectly
authorTony Prisk <linux@prisktech.co.nz>
Wed, 2 Jan 2013 19:44:15 +0000 (08:44 +1300)
committerThierry Reding <thierry.reding@avionic-design.de>
Wed, 9 Jan 2013 07:17:04 +0000 (08:17 +0100)
commit8ab432caa46413c9f3ca81d82ea9fa5bae07c3c1
treea21f94140bdfe4f29a74d42946011f10e729f6c9
parent9421bade0765d8ffb86b8a99213b611278a3542a
pwm: vt8500: Register write busy test performed incorrectly

Correct operation for register writes is to perform a busy-wait
after writing the register. Currently the busy wait it performed
before, meaning subsequent register writes to bitfields may occur
before the previous field has been updated.

Also, all registers are defined as 32-bit read/write. Change
pwm_busy_wait() to use readl rather than readb.

Improve readability of code with defines for registers and bitfields.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
drivers/pwm/pwm-vt8500.c