]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
powerpc/xive: Use xive_cpu->chip_id instead of looking it up again
authorBreno Leitao <breno.leitao@gmail.com>
Thu, 23 Aug 2018 23:26:39 +0000 (20:26 -0300)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 19 Sep 2018 11:58:09 +0000 (21:58 +1000)
commit8ac9e5bfd8cf41ef106ac97267117e5209627c74
treef40cab0b1fdd7cd64c4c335e0abdfbe04da48d65
parent6f8e45f7eb1bee5efdbe4a9cfe4a45627403c5fb
powerpc/xive: Use xive_cpu->chip_id instead of looking it up again

Function xive_native_get_ipi() might use chip_id without it being
initialized, if the CPU node is not found, as reported by smatch:

  error: uninitialized symbol 'chip_id'

As suggested by Cédric, we can use xc->chip_id instead of consulting
the device tree for chip id, which is safe since xive_prepare_cpu()
should have initialized ->chip_id by the time xive_native_get_ipi() is
called.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
[mpe: Tweak change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/sysdev/xive/native.c