]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
perf evlist: Avoid iteration for empty evlist.
authorIan Rogers <irogers@google.com>
Thu, 17 Mar 2022 23:16:43 +0000 (16:16 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 18 Mar 2022 21:39:09 +0000 (18:39 -0300)
commit8b464eac9765dfc84d0327fa3f3668faa439d1ce
tree33b01cedf3690cd112774f742caa9bf470d3cd6f
parent3cf6a32f3f2a45944dd5be5c6ac4deb46bcd3bee
perf evlist: Avoid iteration for empty evlist.

As seen with 'perf stat --null ..' and reported in:
https://lore.kernel.org/lkml/YjCLcpcX2peeQVCH@kernel.org/

v2. Avoids setting evsel in the empty list case as suggested by Jiri Olsa.

    Committer testing:

Before:

  $  perf stat --null sleep 1
  Segmentation fault (core dumped)
  $

After:

  $  perf stat --null sleep 1

   Performance counter stats for 'sleep 1':

         1.010340646 seconds time elapsed

         0.001420000 seconds user
         0.000000000 seconds sys
  $

Fixes: 472832d2c000b961 ("perf evlist: Refactor evlist__for_each_cpu()")
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20220317231643.550902-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evlist.c