]> git.proxmox.com Git - ovs.git/commit
ofp-parse: Remove double uninit of group mod if parsing fails.
authorJarno Rajahalme <jarno@ovn.org>
Fri, 16 Sep 2016 16:39:13 +0000 (09:39 -0700)
committerJarno Rajahalme <jarno@ovn.org>
Fri, 16 Sep 2016 16:39:13 +0000 (09:39 -0700)
commit8b6667285fe17bbc0b41b071d22eec5954ba3eb0
tree5d6d21d4f5861b125334c8f7f2ec988251f17d62
parent258b27d35a8aad8231f8c5308b0d5232dc966915
ofp-parse: Remove double uninit of group mod if parsing fails.

Double ofputil_uninit_group_mod() used to be harmless, but leads to
double free after commit e8dba7197, which will crash if any error in
group parsing happens.

Add a test to prevent this regression from happening again.

Fixes: e8dba7197 ("meta-flow: Compact struct field_array.")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
lib/ofp-parse.c
tests/ofproto-dpif.at