]> git.proxmox.com Git - mirror_qemu.git/commit
iotests: Add -o and --no-opts to _make_test_img
authorMax Reitz <mreitz@redhat.com>
Thu, 7 Nov 2019 16:36:55 +0000 (17:36 +0100)
committerMax Reitz <mreitz@redhat.com>
Mon, 6 Jan 2020 12:43:07 +0000 (13:43 +0100)
commit8b6d7be6a6f8b8e71ab19d63021aad72a0fe1c6b
tree375497c1c17b1deb308118eaa29b3e6774ff2573
parenteea871d047701b563cfd66c1566b9ff6d163882b
iotests: Add -o and --no-opts to _make_test_img

Blindly overriding IMGOPTS is suboptimal as this discards user-specified
options.  Whatever options the test needs should simply be appended.

Some tests do this (with IMGOPTS=$(_optstr_add "$IMGOPTS" "...")), but
that is cumbersome.  It’s simpler to just give _make_test_img an -o
parameter with which tests can add options.

Some tests actually must override the user-specified options, though,
for example when creating an image in a different format than the test
$IMGFMT.  For such cases, --no-opts allows clearing the current option
list.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Message-id: 20191107163708.833192-10-mreitz@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
tests/qemu-iotests/common.rc