]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
serial: sh-sci: Fix out-of-bounds access through DT alias
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 23 Feb 2018 13:38:35 +0000 (14:38 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:29:45 +0000 (12:29 +0200)
commit8b9b821ba728968fc45d03737f41a8ada718cdbf
treef85e7a68ec7de5066b138b8184d1a21a5a917272
parentb7f67bf531b4250438c395713dc8daef39410fc5
serial: sh-sci: Fix out-of-bounds access through DT alias

BugLink: http://bugs.launchpad.net/bugs/1783418
[ Upstream commit 090fa4b0dccfa3d04e1c5ab0fe4eba16e6713895 ]

The sci_ports[] array is indexed using a value derived from the
"serialN" alias in DT, which may lead to an out-of-bounds access.

Fix this by adding a range check.

Note that the array size is defined by a Kconfig symbol
(CONFIG_SERIAL_SH_SCI_NR_UARTS), so this can even be triggered using a
legitimate DTB.

Fixes: 97ed9790c514066b ("serial: sh-sci: Remove unused platform data capabilities field")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/tty/serial/sh-sci.c