]> git.proxmox.com Git - qemu.git/commit
vdi: don't override libuuid symbols
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 20 Nov 2012 15:34:17 +0000 (16:34 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 21 Nov 2012 08:40:29 +0000 (09:40 +0100)
commit8ba2aae32c40f544def6be7ae82be9bcb781e01d
tree135f262987e206ef8b2840474913ca42a8d60737
parent1bc6b705eed02dab9feb0e663219b5623f3d684d
vdi: don't override libuuid symbols

It's poor symbol hygiene to provide a global symbols that collide with a
common library like libuuid.  If QEMU links against a shared library
that depends on uuid_generate() it can end up calling our stub version
of the function.

This exact scenario happened with GlusterFS libgfapi.so, which depends
on libglusterfs.so's uuid_generate().

Scope the uuid stubs for vdi.c only and avoid affecting other shared
objects.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
block/vdi.c