]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
fm10k: correctly pack TLV structures and explain reasoning
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 9 Nov 2015 22:04:08 +0000 (14:04 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 22 Dec 2015 12:32:14 +0000 (04:32 -0800)
commit8c2a029c7eff14510fed04cef2848c6d21ed92dd
treeac410d69617d6676c4066641a10f0bb3cf788ea6
parent07146e2ea8d878d3bfb8d7d3424350d447e0166f
fm10k: correctly pack TLV structures and explain reasoning

The TLV format for little endian structures is actually 4 byte aligned
copy. To this end, we need to add an additional __aligned(4) marker
along with __packed to ensure that these structures are actually 4 byte
aligned and packed correctly. Use of just __packed will not work as this
will result in 1byte alignment which is incorrect. Add a comment
explaining the reasoning behind why these structures need the special
treatment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pf.h