]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
net/mlx5e: Verify that rule has at least one fwd/drop action
authorVlad Buslov <vladbu@mellanox.com>
Wed, 11 Sep 2019 18:14:54 +0000 (21:14 +0300)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 6 Jan 2020 14:16:09 +0000 (08:16 -0600)
commit8c5bb25f8919c3542457ae606abac66bcfb9ae58
tree81ad2ca06495b7fad3c6625a9e45ee631ad3435a
parentb2df34c210a245d9e225fdfa5c4979632d5f4f07
net/mlx5e: Verify that rule has at least one fwd/drop action

BugLink: https://bugs.launchpad.net/bugs/1858428
[ Upstream commit ae2741e2b6ce2bf1b656b1152c4ef147ff35b096 ]

Currently, mlx5 tc layer doesn't verify that rule has at least one forward
or drop action which leads to following firmware syndrome when user tries
to offload such action:

[ 1824.860501] mlx5_core 0000:81:00.0: mlx5_cmd_check:753:(pid 29458): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x144b7a)

Add check at the end of parse_tc_fdb_actions() that verifies that resulting
attribute has action fwd or drop flag set.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c