]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
clk: mvebu: Off by one bugs in cp110_of_clk_get()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 3 Dec 2018 14:50:55 +0000 (17:50 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit8d006975bb93718017e9d2a5ab46d359d001a4e6
tree5d8ca57429e51537379bd66cf2df21a2ecbc22e2
parentd83896bc1512010c3f7ba45e6c5e54d2ecf73c6d
clk: mvebu: Off by one bugs in cp110_of_clk_get()

BugLink: https://bugs.launchpad.net/bugs/1837257
[ Upstream commit d9f5b7f5dd0fa74a89de5a7ac1e26366f211ccee ]

These > comparisons should be >= to prevent reading beyond the end of
of the clk_data->hws[] buffer.

The clk_data->hws[] array is allocated in cp110_syscon_common_probe()
when we do:
cp110_clk_data = devm_kzalloc(dev, sizeof(*cp110_clk_data) +
      sizeof(struct clk_hw *) * CP110_CLK_NUM,
      GFP_KERNEL);
As you can see, it has CP110_CLK_NUM elements which is equivalent to
CP110_MAX_CORE_CLOCKS + CP110_MAX_GATABLE_CLOCKS.

Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/clk/mvebu/cp110-system-controller.c