]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/exynos: fix a wrong error checking
authorInki Dae <inki.dae@samsung.com>
Wed, 1 Nov 2023 09:36:51 +0000 (18:36 +0900)
committerInki Dae <inki.dae@samsung.com>
Thu, 7 Dec 2023 02:51:43 +0000 (11:51 +0900)
commit8d1b7809684c688005706125b804e1f9792d2b1b
tree02c6cff1a21087b7763e9a518d9fcd013f6fc86b
parent73bf1c9ae6c054c53b8e84452c5e46f86dd28246
drm/exynos: fix a wrong error checking

Fix a wrong error checking in exynos_drm_dma.c module.

In the exynos_drm_register_dma function, both arm_iommu_create_mapping()
and iommu_get_domain_for_dev() functions are expected to return NULL as
an error.

However, the error checking is performed using the statement
if(IS_ERR(mapping)), which doesn't provide a suitable error value.
So check if 'mapping' is NULL, and if it is, return -ENODEV.

This issue[1] was reported by Dan.

Changelog v1:
- fix build warning.

[1] https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/

Reported-by : Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_dma.c