]> git.proxmox.com Git - mirror_qemu.git/commit
file-posix: Forbid trying to change unsupported options during reopen
authorAlberto Garcia <berto@igalia.com>
Thu, 6 Sep 2018 09:37:07 +0000 (12:37 +0300)
committerKevin Wolf <kwolf@redhat.com>
Mon, 1 Oct 2018 10:51:12 +0000 (12:51 +0200)
commit8d3245750be30f3191f710f52fbe53ca10e78bfc
tree9186029d7739e3d655ed1c3cfdd17a26243b1378
parent57f9db9a947f4d32bbd56ed9b1e0989f6c306dfb
file-posix: Forbid trying to change unsupported options during reopen

The file-posix code is used for the "file", "host_device" and
"host_cdrom" drivers, and it allows reopening images. However the only
option that is actually processed is "x-check-cache-dropped", and
changes in all other options (e.g. "filename") are silently ignored:

   (qemu) qemu-io virtio0 "reopen -o file.filename=no-such-file"

While we could allow changing some of the other options, let's keep
things as they are for now but return an error if the user tries to
change any of them.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/file-posix.c