]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
watchdog: Fix CPU hotplug regression
authorThomas Gleixner <tglx@linutronix.de>
Tue, 4 Dec 2012 17:59:34 +0000 (18:59 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 4 Dec 2012 18:56:59 +0000 (19:56 +0100)
commit8d4516904b39507458bee8115793528e12b1d8dd
tree4afc56d198921b85f61918c2478cfc93fb2dc96e
parentb69f0859dc8e633c5d8c06845811588fe17e68b3
watchdog: Fix CPU hotplug regression

Norbert reported:
"3.7-rc6 booted with nmi_watchdog=0 fails to suspend to RAM or
 offline CPUs. It's reproducable with a KVM guest and physical
 system."

The reason is that commit bcd951cf(watchdog: Use hotplug thread
infrastructure) missed to take this into account. So the cpu offline
code gets stuck in the teardown function because it accesses non
initialized data structures.

Add a check for watchdog_enabled into that path to cure the issue.

Reported-and-tested-by: Norbert Warmuth <nwarmuth@t-online.de>
Tested-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1211231033230.2701@ionos
Link: http://bugs.launchpad.net/bugs/1079534
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/watchdog.c