]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
scsi: qla2xxx: Really fix qla2xxx_eh_abort()
authorBart Van Assche <bvanassche@acm.org>
Fri, 9 Aug 2019 03:01:23 +0000 (20:01 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Aug 2019 01:34:04 +0000 (21:34 -0400)
commit8dd9593cc07ad7d999bef81b06789ef873a94881
tree5abbcf569f1561782851203670deca81c5e6ab2c
parentd2d2b5a5741d317bed1fa38211f1f3b142d8cf7a
scsi: qla2xxx: Really fix qla2xxx_eh_abort()

I'm not sure how this happened but the patch that was intended to fix abort
handling was incomplete. This patch fixes that patch as follows:

 - If aborting the SCSI command failed, wait until the SCSI command
   completes.

 - Return SUCCESS instead of FAILED if an abort attempt races with SCSI
   command completion.

 - Since qla2xxx_eh_abort() increments the sp reference count by calling
   sp_get(), decrement the sp reference count before returning.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c