]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()
authorPeilin Ye <yepeilin.cs@gmail.com>
Tue, 28 Jul 2020 19:29:24 +0000 (15:29 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Jul 2020 19:36:44 +0000 (15:36 -0400)
commit8e326285924cd13d9d94edc209440ef5b6f85085
tree3883591994fc50f758ee39a84b56960c880e4c8c
parent7619517598ad5ba04beb855cde6558e72c73dbb5
drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

Compiler leaves a 4-byte hole near the end of `dev_info`, causing
amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace
when `size` is greater than 356.

In 2015 we tried to fix this issue by doing `= {};` on `dev_info`, which
unfortunately does not initialize that 4-byte hole. Fix it by using
memset() instead.

Cc: stable@vger.kernel.org
Fixes: c193fa91b918 ("drm/amdgpu: information leak in amdgpu_info_ioctl()")
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c