]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Aug 2017 22:34:45 +0000 (17:34 -0500)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 9 Aug 2017 10:09:19 +0000 (13:09 +0300)
commit8e374f0add2dc153d270757a71de45a0ba7d7004
tree702383d0501b4d48bc10334acd058110517bef33
parentb765ff181ef64c56fad5cba31c1856fe8ef92d3c
usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

platform_get_irq() returns an error code, but the renesas_usb3 driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print error message and propagate the return value of platform_get_irq
on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/renesas_usb3.c