]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
udf: Allow mounting volumes with incorrect identification strings
authorJan Kara <jack@suse.cz>
Fri, 16 Nov 2018 12:43:17 +0000 (13:43 +0100)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:44:59 +0000 (09:44 -0600)
commit8e397b2086b1a2b7578b491cad69e8fefce09a68
treebba355945a433fbe622c8fe937c5d268547bf487
parent7cb0f5ccc481d2f85676b4a00266a3a90fdc5a42
udf: Allow mounting volumes with incorrect identification strings

BugLink: https://bugs.launchpad.net/bugs/1836968
commit b54e41f5efcb4316b2f30b30c2535cc194270373 upstream.

Commit c26f6c615788 ("udf: Fix conversion of 'dstring' fields to UTF8")
started to be more strict when checking whether converted strings are
properly formatted. Sudip reports that there are DVDs where the volume
identification string is actually too long - UDF reports:

[  632.309320] UDF-fs: incorrect dstring lengths (32/32)

during mount and fails the mount. This is mostly harmless failure as we
don't need volume identification (and even less volume set
identification) for anything. So just truncate the volume identification
string if it is too long and replace it with 'Invalid' if we just cannot
convert it for other reasons. This keeps slightly incorrect media still
mountable.

CC: stable@vger.kernel.org
Fixes: c26f6c615788 ("udf: Fix conversion of 'dstring' fields to UTF8")
Reported-and-tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/udf/super.c
fs/udf/unicode.c