]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
perf tools: Use readdir() instead of deprecated readdir_r() again
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 8 Apr 2016 14:53:02 +0000 (11:53 -0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Fri, 11 Aug 2017 10:36:53 +0000 (12:36 +0200)
commit8e48e7d25be9d6c405eb1be439c3373360ff6829
treefc23e95bff7007e391deb7a7d2fe364c6e6576e7
parent3d42d7c3cc1297d153ee07eaeadf3685b88b69c9
perf tools: Use readdir() instead of deprecated readdir_r() again

BugLink: http://bugs.launchpad.net/bugs/1705238
commit 22a9f41b555673e7499b97acf3ffb07bf0af31ad upstream.

The readdir() function is thread safe as long as just one thread uses a
DIR, which is the case when parsing tracepoint event definitions, to
avoid breaking the build with glibc-2.23.90 (upcoming 2.24), use it
instead of readdir_r().

See: http://man7.org/linux/man-pages/man3/readdir.3.html

"However, in modern implementations (including the glibc implementation),
concurrent calls to readdir() that specify different directory streams
are thread-safe.  In cases where multiple threads must read from the
same directory stream, using readdir() with external synchronization is
still preferable to the use of the deprecated readdir_r(3) function."

Noticed while building on a Fedora Rawhide docker container.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-wddn49r6bz6wq4ee3dxbl7lo@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
tools/perf/util/parse-events.c