]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
perf tools: Do not zero sample_id_all for group members
authorJiri Olsa <jolsa@kernel.org>
Sun, 23 Sep 2018 15:04:20 +0000 (17:04 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 6 Nov 2018 11:29:56 +0000 (08:29 -0300)
commit8e88c29b351ed4e09dd63f825f1c8260b0cb0ab3
treeb7e0e6eb69b055ecb3c9ea0d93423cdaa297b8fa
parent6ac2226229d931153331a93d90655a3de05b9290
perf tools: Do not zero sample_id_all for group members

Andi reported following malfunction:

  # perf record -e '{ref-cycles,cycles}:S' -a sleep 1
  # perf script
  non matching sample_id_all

That's because we disable sample_id_all bit for non-sampling group
members. We can't do that, because it needs to be the same over the
whole event list. This patch keeps it untouched again.

Reported-by: Andi Kleen <andi@firstfloor.org>
Tested-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180923150420.27327-1-jolsa@kernel.org
Fixes: e9add8bac6c6 ("perf evsel: Disable write_backward for leader sampling group events")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/attr/test-record-group-sampling
tools/perf/util/evsel.c