]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
x86: Avoid pr_cont() in show_opcodes()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 19 Jul 2018 14:07:58 +0000 (23:07 +0900)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 19 Jul 2018 14:46:23 +0000 (16:46 +0200)
commit8e974b3b8eddd42a8c43a18e8ea66a3e7b803a0d
treea4f022326531962d53f7744e7d1460bbb0eebe47
parent9d3cce1e8b8561fed5f383d22a4d6949db4eadbe
x86: Avoid pr_cont() in show_opcodes()

If concurrent printk() messages are emitted, then pr_cont() is making it
extremly hard to decode which part of the output belongs to what. See the
convoluted example at:

  https://syzkaller.appspot.com/text?tag=CrashReport&x=139d342c400000

Avoid this by using a proper prefix for each line and by using %ph format
in show_opcodes() which emits the 'Code:' line in one go.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: joe@perches.com
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@suse.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lkml.kernel.org/r/1532009278-5953-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
arch/x86/kernel/dumpstack.c