]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ASoC: bcm2835: Enforce full symmetry
authorMatthias Reichl <hias@horus.com>
Sun, 7 May 2017 14:24:57 +0000 (16:24 +0200)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 9 Mar 2018 15:21:09 +0000 (12:21 -0300)
commit8f040fe0d8d99a08126fe164c81d3b7c337845b2
treedbe6168ec10c080f21cdae7cd5eda9dfabae5f19
parent0a6e2b7f0a27fd225964cbbb80a063b07aaeb136
ASoC: bcm2835: Enforce full symmetry

bcm2835's configuration registers can't be changed when a stream
is running, which means asymmetric configurations aren't supported.

Channel and rate symmetry are already enforced by constraints
but samplebits had been missed.

As hw_params doesn't check for symmetry constraints by itself
and just returns success if a stream is running this led to
situations where asymmetric configurations were seeming to
succeed but of course didn't work because the hardware wasn't
configured at all.

Fix this by adding the missing samplerate symmetry constraint.

Signed-off-by: Matthias Reichl <hias@horus.com>
sound/soc/bcm/bcm2835-i2s.c