]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: x86/twofish - Fix RBP usage
authorJosh Poimboeuf <jpoimboe@redhat.com>
Mon, 18 Sep 2017 19:42:11 +0000 (14:42 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 20 Sep 2017 09:42:38 +0000 (17:42 +0800)
commit8f182f845d0fa26ecc18d3bdcc3d1077a0ea3a31
treed8161aeaa48bc2f93de4eee69cfa9d535fbf5f18
parentca04c823763e5b82c237cabe0c17f547ecdc6271
crypto: x86/twofish - Fix RBP usage

Using RBP as a temporary register breaks frame pointer convention and
breaks stack traces when unwinding from an interrupt in the crypto code.

Use R13 instead of RBP.  Both are callee-saved registers, so the
substitution is straightforward.

Reported-by: Eric Biggers <ebiggers@google.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Eric Biggers <ebiggers@google.com>
Acked-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/twofish-avx-x86_64-asm_64.S