]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ext4: set error return correctly when ext4_htree_store_dirent fails
authorColin Ian King <colin.king@canonical.com>
Mon, 12 Aug 2019 18:29:38 +0000 (14:29 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit8f4489165f779eaab8673700e766920bd1ac8fe3
tree42eb2038b233ddd014798773f024f6b158251c9a
parentdf785c247b6c55a3e773745b1cfecb287d952653
ext4: set error return correctly when ext4_htree_store_dirent fails

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 7a14826ede1d714f0bb56de8167c0e519041eeda ]

Currently when the call to ext4_htree_store_dirent fails the error return
variable 'ret' is is not being set to the error code and variable count is
instead, hence the error code is not being returned.  Fix this by assigning
ret to the error return code.

Addresses-Coverity: ("Unused value")
Fixes: 8af0f0822797 ("ext4: fix readdir error in the case of inline_data+dir_index")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ext4/inline.c