]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()
authorWei Chen <harperchen1110@gmail.com>
Sun, 26 Mar 2023 05:31:38 +0000 (05:31 +0000)
committerKalle Valo <kvalo@kernel.org>
Fri, 31 Mar 2023 14:51:02 +0000 (17:51 +0300)
commit905a9241e4e8c15d2c084fee916280514848fe35
tree2436f84fc3db3672ad4f94cd35c80607d40e01b6
parent5aeb763a27c2b444928639d35cbe94520c405969
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()

If there is a failure during copy_from_user or user-provided data buffer
is invalid, rtl_debugfs_set_write_rfreg should return negative error code
instead of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326053138.91338-1-harperchen1110@gmail.com
drivers/net/wireless/realtek/rtlwifi/debug.c