]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ALSA: declare snd_kcontrol_new structures as const
authorBhumika Goyal <bhumirks@gmail.com>
Sat, 27 May 2017 14:46:15 +0000 (20:16 +0530)
committerTakashi Iwai <tiwai@suse.de>
Tue, 30 May 2017 08:29:25 +0000 (10:29 +0200)
commit905e46acd3272d04566fec49afbd7ad9e2ed9ae3
tree6a08cef18f2864a704a5c04d604d4b75738cc669
parent2c4842d3b6b3cf6db0f21e487da7e9bd3aa23090
ALSA: declare snd_kcontrol_new structures as const

Declare snd_kcontrol_new structures as const as they are only passed an
argument to the function snd_ctl_new1. This argument is of type const,
so snd_kcontrol_new structures having this property can be made const.
Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

Cross compiled these files:
sound/aoa/codecs/tas.c - powerpc
sound/mips/{hal2.c/sgio2audio.c} - mips
sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
sound/soc/sh/siu_dai.c - sh
Could not find an architecture to compile sound/sh/aica.c.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
14 files changed:
sound/aoa/codecs/tas.c
sound/aoa/fabrics/layout.c
sound/core/ctljack.c
sound/drivers/vx/vx_mixer.c
sound/firewire/bebob/bebob_maudio.c
sound/mips/hal2.c
sound/mips/sgio2audio.c
sound/pcmcia/vx/vxp_mixer.c
sound/ppc/awacs.c
sound/ppc/beep.c
sound/ppc/tumbler.c
sound/sh/aica.c
sound/soc/sh/siu_dai.c
sound/usb/mixer_quirks.c