]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ktest.pl: Fix missing "end_monitor" when machine check fails
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 18 Jan 2023 16:31:25 +0000 (11:31 -0500)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 14 Mar 2023 15:47:38 +0000 (16:47 +0100)
commit90961d7863f2ee3063241dd5df6761b10d8b7c8b
treea941fbf02615b4f0cc891b86689dac174b2e3275
parent6cf2721f7f5832cb596d5088ed231ea72ffec0df
ktest.pl: Fix missing "end_monitor" when machine check fails

BugLink: https://bugs.launchpad.net/bugs/2011425
commit e8bf9b98d40dbdf4e39362e3b85a70c61da68cb7 upstream.

In the "reboot" command, it does a check of the machine to see if it is
still alive with a simple "ssh echo" command. If it fails, it will assume
that a normal "ssh reboot" is not possible and force a power cycle.

In this case, the "start_monitor" is executed, but the "end_monitor" is
not, and this causes the screen will not be given back to the console. That
is, after the test, a "reset" command needs to be performed, as "echo" is
turned off.

Cc: stable@vger.kernel.org
Fixes: 6474ace999edd ("ktest.pl: Powercycle the box on reboot if no connection can be made")
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
tools/testing/ktest/ktest.pl