]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ceph: hold extra reference to r_parent over life of request
authorJeff Layton <jlayton@kernel.org>
Wed, 3 Apr 2019 17:16:01 +0000 (13:16 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 6 Mar 2020 07:25:26 +0000 (02:25 -0500)
commit90bc5352c0e675d5280b56413c9f5a73f07964e1
treef1a129b59c58e2bc160efc939df8ca79021dc14a
parent549c13a60e4ef3f99fdae75eb4e997beb24d812c
ceph: hold extra reference to r_parent over life of request

BugLink: https://bugs.launchpad.net/bugs/1864710
commit 9c1c2b35f1d94de8325344c2777d7ee67492db3b upstream.

Currently, we just assume that it will stick around by virtue of the
submitter's reference, but later patches will allow the syscall to
return early and we can't rely on that reference at that point.

While I'm not aware of any reports of it, Xiubo pointed out that this
may fix a use-after-free.  If the wait for a reply times out or is
canceled via signal, and then the reply comes in after the syscall
returns, the client can end up trying to access r_parent without a
reference.

Take an extra reference to the inode when setting r_parent and release
it when releasing the request.

Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ceph/mds_client.c