]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
iio: adc: gyroadc: fix uninitialized return code
authorArnd Bergmann <arnd@arndb.de>
Thu, 18 Jul 2019 13:57:49 +0000 (15:57 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 27 Jul 2019 20:56:59 +0000 (21:56 +0100)
commit90c6260c1905a68fb596844087f2223bd4657fee
treebfbbdf0822c7e68fca93d0058cc9dd151b543e11
parent41e6ada93356400ec8bc8dba04818d9e30ee6e9d
iio: adc: gyroadc: fix uninitialized return code

gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where
we accidentally return 0 on failure.

Cc: stable@vger.kernel.org
Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/rcar-gyroadc.c