]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
netfilter: x_tables: xt_mttg_seq_next should increase position index
authorVasily Averin <vvs@virtuozzo.com>
Tue, 25 Feb 2020 07:07:12 +0000 (10:07 +0300)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 18 Mar 2020 10:39:15 +0000 (11:39 +0100)
commit90ffe522b6aeebf0b462c589eea289b147d1a174
treee338c17b732c1ce5b1aa4798da2621d13c749633
parent8d3af60c55977a258353c5a9578d102afa32d4a8
netfilter: x_tables: xt_mttg_seq_next should increase position index

BugLink: https://bugs.launchpad.net/bugs/1867903
commit ee84f19cbbe9cf7cba2958acb03163fed3ecbb0f upstream.

If .next function does not change position index,
following .show function will repeat output related
to current position index.

Without patch:
 # dd if=/proc/net/ip_tables_matches  # original file output
 conntrack
 conntrack
 conntrack
 recent
 recent
 icmp
 udplite
 udp
 tcp
 0+1 records in
 0+1 records out
 65 bytes copied, 5.4074e-05 s, 1.2 MB/s

 # dd if=/proc/net/ip_tables_matches bs=62 skip=1
 dd: /proc/net/ip_tables_matches: cannot skip to specified offset
 cp   <<< end of  last line
 tcp  <<< and then unexpected whole last line once again
 0+1 records in
 0+1 records out
 7 bytes copied, 0.000102447 s, 68.3 kB/s

Cc: stable@vger.kernel.org
Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code ...")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206283
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
net/netfilter/x_tables.c