]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
PM: EM: postpone creating the debugfs dir till fs_initcall
authorLukasz Luba <lukasz.luba@arm.com>
Tue, 23 Mar 2021 14:56:08 +0000 (14:56 +0000)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 8 Apr 2021 20:42:38 +0000 (15:42 -0500)
commit9106189734d73cc2144a8ff8f07562c58bf4b6ed
tree87a75db79dd9cc74c885c67e054e88c491e29fe3
parente051f2aff8627f324194b96d785fa430503e4475
PM: EM: postpone creating the debugfs dir till fs_initcall

BugLink: https://bugs.launchpad.net/bugs/1922601
[ Upstream commit fb9d62b27ab1e07d625591549c314b7d406d21df ]

The debugfs directory '/sys/kernel/debug/energy_model' is needed before
the Energy Model registration can happen. With the recent change in
debugfs subsystem it's not allowed to create this directory at early
stage (core_initcall). Thus creating this directory would fail.

Postpone the creation of the EM debug dir to later stage: fs_initcall.

It should be safe since all clients: CPUFreq drivers, Devfreq drivers
will be initialized in later stages.

The custom debug log below prints the time of creation the EM debug dir
at fs_initcall and successful registration of EMs at later stages.

[    1.505717] energy_model: creating rootdir
[    3.698307] cpu cpu0: EM: created perf domain
[    3.709022] cpu cpu1: EM: created perf domain

Fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized")
Reported-by: Ionela Voinescu <ionela.voinescu@arm.com>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
kernel/power/energy_model.c