]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
rcu: Allow for page faults in NMI handlers
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Fri, 22 Sep 2017 21:10:22 +0000 (14:10 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 30 Oct 2017 13:47:58 +0000 (14:47 +0100)
commit9112cdadd0f4ab70f2fc1ae85dd2557a8b436e84
treeabdd450789e8168c6f6c27366fe3ada6853f0a75
parent83b5afd84b52292641d3ba756c72fa011ea22272
rcu: Allow for page faults in NMI handlers

BugLink: http://bugs.launchpad.net/bugs/1724836
commit 28585a832602747cbfa88ad8934013177a3aae38 upstream.

A number of architecture invoke rcu_irq_enter() on exception entry in
order to allow RCU read-side critical sections in the exception handler
when the exception is from an idle or nohz_full CPU.  This works, at
least unless the exception happens in an NMI handler.  In that case,
rcu_nmi_enter() would already have exited the extended quiescent state,
which would mean that rcu_irq_enter() would (incorrectly) cause RCU
to think that it is again in an extended quiescent state.  This will
in turn result in lockdep splats in response to later RCU read-side
critical sections.

This commit therefore causes rcu_irq_enter() and rcu_irq_exit() to
take no action if there is an rcu_nmi_enter() in effect, thus avoiding
the unscheduled return to RCU quiescent state.  This in turn should
make the kernel safe for on-demand RCU voyeurism.

Link: http://lkml.kernel.org/r/20170922211022.GA18084@linux.vnet.ibm.com
Cc: stable@vger.kernel.org
Fixes: 0be964be0 ("module: Sanitize RCU usage and locking")
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
kernel/rcu/tree.c