]> git.proxmox.com Git - mirror_qemu.git/commit
hmp: fix bad value conversion for M type
authorLuiz Capitulino <lcapitulino@redhat.com>
Thu, 26 Apr 2012 20:34:30 +0000 (17:34 -0300)
committerLuiz Capitulino <lcapitulino@redhat.com>
Tue, 8 May 2012 17:30:22 +0000 (14:30 -0300)
commit911628498cea6617243761babbbacaeb8b3a062a
treec8eea42cf889a8714db83cac9a4ffa4e22c0a5db
parent6b0e33be88bbccc3bcb987026089aa09f9622de9
hmp: fix bad value conversion for M type

The M type converts from megabytes to bytes. However, the value can be
negative before the conversion, which will lead to a flawed conversion.

For example, this:

 (qemu) balloon -1000000000000011
 (qemu)

Just "works", but the value passed by the balloon command will be
something else.

This patch fixes this problem by requering a positive value before
converting. There's really no reason to accept a negative value for
the M type.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
monitor.c