]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/rockchip: Finish initialization before registering DRM device
authorTomasz Figa <tfiga@chromium.org>
Tue, 21 Jun 2016 04:27:34 +0000 (13:27 +0900)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 Jun 2016 08:52:58 +0000 (10:52 +0200)
commit9127f99c4801f323ffbb3b755259f3a679f66c7c
tree60df493b2d714ac81a6cb0cf81e593f33f4e2489
parent41719d581a1e5ba8f4c5d0fc9181c3cd5bef5019
drm/rockchip: Finish initialization before registering DRM device

Currently the driver calls drm_dev_register() directly after allocating
the DRM device and then continues with further initialization. This is
incorrect, because drm_dev_register() is supposed to be called after all
initialization is done. This problem was masked by the fact that
drm_dev_register() did not use to do anything special before, but
recently it started to call drm_connector_register_all(), which leads to
a crash if the driver is not fully initialized.

This patch fixes the problem by moving the call to drm_dev_register() to
the end of the initialization sequence and also removing the, now
unnecessary, call to drm_connector_register_all() from driver code.

Fixes: f706974a69b6 ("drm/rockchip: Drop drm_driver.load/unload callbacks")
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
[danvet: Fix up cleanup labels a bit.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466483254-35373-1-git-send-email-tfiga@chromium.org
drivers/gpu/drm/rockchip/rockchip_drm_drv.c