]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/bridge: nxp-ptn3460: fix i2c_master_send() error checking
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 4 Dec 2023 12:29:00 +0000 (15:29 +0300)
committerRobert Foss <rfoss@kernel.org>
Mon, 4 Dec 2023 13:05:31 +0000 (14:05 +0100)
commit914437992876838662c968cb416f832110fb1093
tree2b809c25cdcde57f417e8b77cd5b2a47df217d53
parentf6d8a80f1d10ff01cff3ac26e242165a270bbbad
drm/bridge: nxp-ptn3460: fix i2c_master_send() error checking

The i2c_master_send/recv() functions return negative error codes or the
number of bytes that were able to be sent/received.  This code has
two problems.  1)  Instead of checking if all the bytes were sent or
received, it checks that at least one byte was sent or received.
2) If there was a partial send/receive then we should return a negative
error code but this code returns success.

Fixes: a9fe713d7d45 ("drm/bridge: Add PTN3460 bridge driver")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/0cdc2dce-ca89-451a-9774-1482ab2f4762@moroto.mountain
drivers/gpu/drm/bridge/nxp-ptn3460.c