]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xdp: bpf_xdp_metadata use EOPNOTSUPP for no driver support
authorJesper Dangaard Brouer <brouer@redhat.com>
Tue, 21 Mar 2023 13:52:31 +0000 (14:52 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 22 Mar 2023 16:11:09 +0000 (09:11 -0700)
commit915efd8a446b74442039d31689d5d863caf82517
treebd417ce544be51d970db509dc5672a18de206d21
parent10ec8ca8ec1a2f04c4ed90897225231c58c124a7
xdp: bpf_xdp_metadata use EOPNOTSUPP for no driver support

When driver doesn't implement a bpf_xdp_metadata kfunc the fallback
implementation returns EOPNOTSUPP, which indicate device driver doesn't
implement this kfunc.

Currently many drivers also return EOPNOTSUPP when the hint isn't
available, which is ambiguous from an API point of view. Instead
change drivers to return ENODATA in these cases.

There can be natural cases why a driver doesn't provide any hardware
info for a specific hint, even on a frame to frame basis (e.g. PTP).
Lets keep these cases as separate return codes.

When describing the return values, adjust the function kernel-doc layout
to get proper rendering for the return values.

Fixes: ab46182d0dcb ("net/mlx4_en: Support RX XDP metadata")
Fixes: bc8d405b1ba9 ("net/mlx5e: Support RX XDP metadata")
Fixes: 306531f0249f ("veth: Support RX XDP metadata")
Fixes: 3d76a4d3d4e5 ("bpf: XDP metadata RX kfuncs")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/167940675120.2718408.8176058626864184420.stgit@firesoul
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Documentation/networking/xdp-rx-metadata.rst
drivers/net/ethernet/mellanox/mlx4/en_rx.c
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
drivers/net/veth.c
net/core/xdp.c