]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
USB: serial: digi_acceleport: fix OOB data sanity check
authorJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 16:17:27 +0000 (17:17 +0100)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 20 Mar 2017 11:24:55 +0000 (05:24 -0600)
commit91c01886395c18e79cf3b6942d93ca678ea5a0fd
tree1aca51531e871c8619165bd746fcbd2a2b548fbf
parentabe9c1f5504ded343b0968f85134950f7bc0ed74
USB: serial: digi_acceleport: fix OOB data sanity check

BugLink: http://bugs.launchpad.net/bugs/1674288
commit 2d380889215fe20b8523345649dee0579821800c upstream.

Make sure to check for short transfers to avoid underflow in a loop
condition when parsing the receive buffer.

Also fix an off-by-one error in the incomplete sanity check which could
lead to invalid data being parsed.

Fixes: 8c209e6782ca ("USB: make actual_length in struct urb field u32")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/usb/serial/digi_acceleport.c