]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
powerpc/wii: Fix declaration made after definition
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 13 Apr 2020 19:06:45 +0000 (12:06 -0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 20 May 2020 13:39:56 +0000 (23:39 +1000)
commit91ffeaa7e5dd62753e23a1204dc7ecd11f26eadc
tree089830440164983e2c896376bf8c7b2632328125
parentc2e929b18cea6cbf71364f22d742d9aad7f4677a
powerpc/wii: Fix declaration made after definition

A 0day randconfig uncovered an error with clang, trimmed for brevity:

arch/powerpc/platforms/embedded6xx/wii.c:195:7: error: attribute
declaration must precede definition [-Werror,-Wignored-attributes]
        if (!machine_is(wii))
             ^

The macro machine_is declares mach_##name but define_machine actually
defines mach_##name, hence the warning.

To fix this, move define_machine after the is_machine usage.

Fixes: 5a7ee3198dfa ("powerpc: wii: platform support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://github.com/ClangBuiltLinux/linux/issues/989
Link: https://lore.kernel.org/r/20200413190644.16757-1-natechancellor@gmail.com
arch/powerpc/platforms/embedded6xx/wii.c