]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mmc: sdhci-esdhc-imx: correct CQHCI exit halt state check
authorSebastian Falbesoner <sebastian.falbesoner@gmail.com>
Mon, 21 Nov 2022 10:57:21 +0000 (11:57 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:02:50 +0000 (14:02 +0100)
commit920e48dd6001c255ef93f4aaac5969f0f8f26bae
treefa3bd6055aa79dedb224d5e6330b3133b17b3e39
parent7d4740270af94887ef0bc80a8a8c49c753757f8c
mmc: sdhci-esdhc-imx: correct CQHCI exit halt state check

commit a3cab1d2132474969871b5d7f915c5c0167b48b0 upstream.

With the current logic the "failed to exit halt state" error would be
shown even if any other bit than CQHCI_HALT was set in the CQHCI_CTL
register, since the right hand side is always true. Fix this by using
the correct operator (bit-wise instead of logical AND) to only check for
the halt bit flag, which was obviously intended here.

Fixes: 85236d2be844 ("mmc: sdhci-esdhc-imx: clear the HALT bit when enable CQE")
Signed-off-by: Sebastian Falbesoner <sebastian.falbesoner@gmail.com>
Acked-by: Haibo Chen <haibo.chen@nxp.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221121105721.1903878-1-sebastian.falbesoner@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 4c7681c1a52fb6cb5b370635d27df7f610f554e7)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
drivers/mmc/host/sdhci-esdhc-imx.c