]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
iio: tsl2583: Fix division by a zero lux_val
authorColin Ian King <colin.king@canonical.com>
Fri, 7 May 2021 18:30:41 +0000 (19:30 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 18 Jun 2021 13:02:19 +0000 (15:02 +0200)
commit923947e589f7036a1a3c2dc5fd63632e702df22f
treefeb7cdcaa882b812c3d942ef8fe93fdcaad71a65
parentfddb224a936c2a5b84eea2e487d8c1d271d512e3
iio: tsl2583: Fix division by a zero lux_val

BugLink: https://bugs.launchpad.net/bugs/1930474
commit af0e1871d79cfbb91f732d2c6fa7558e45c31038 upstream.

The lux_val returned from tsl2583_get_lux can potentially be zero,
so check for this to avoid a division by zero and an overflowed
gain_trim_val.

Fixes clang scan-build warning:

drivers/iio/light/tsl2583.c:345:40: warning: Either the
condition 'lux_val<0' is redundant or there is division
by zero at line 345. [zerodivcond]

Fixes: ac4f6eee8fe8 ("staging: iio: TAOS tsl258x: Device driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/iio/light/tsl2583.c