]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
kbuild: store the objtool command in *.cmd files
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 31 Aug 2021 07:39:54 +0000 (16:39 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Wed, 22 Sep 2021 00:26:25 +0000 (09:26 +0900)
commit92594d569b6d377168fa74c6bb27c5696af02a9d
tree9da76330e2a0ebaa40318cc66c335b8e71c7f9d2
parent5c4859e77aa11f9a8d9533962389893d199df70e
kbuild: store the objtool command in *.cmd files

objtool_dep includes include/config/{ORC_UNWINDER,STACK_VALIDATION}
so that all the objects are rebuilt when CONFIG_ORC_UNWINDER or
CONFIG_STACK_VALIDATION is toggled.

BTW, the correct option name is not CONFIG_ORC_UNWINDER, but
CONFIG_UNWINDER_ORC. Commit 11af847446ed ("x86/unwind: Rename
unwinder config options to 'CONFIG_UNWINDER_*'") missed to
adjust this part. So, this dependency has been broken for a
long time.

As you can see in 'objtool_args', there are more CONFIG options
that affect the objtool command line.

Adding more and more include/config/* is ugly and unmaintainable.

Another issue is that non-standard objects are needlessly rebuilt.
Objects specified as OBJECT_FILES_NON_STANDARD is not processed by
objtool, but they are rebuilt anyway when CONFIG_STACK_VALIDATION
is toggled. This is not a big deal, but better to fix.

A cleaner and more precise fix is to include the objtool command in
*.cmd files so any command change is naturally detected by if_change.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
scripts/Makefile.build