]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ipv6 mcast: use in6_dev_put in timer handlers instead of __in6_dev_put
authorSalam Noureddine <noureddine@aristanetworks.com>
Sun, 29 Sep 2013 20:41:34 +0000 (13:41 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Oct 2013 05:28:58 +0000 (22:28 -0700)
commit9260d3e1013701aa814d10c8fc6a9f92bd17d643
tree16adfb29127e0f28451e3a42bf0b1242ec5c10e7
parente2401654dd0f5f3fb7a8d80dad9554d73d7ca394
ipv6 mcast: use in6_dev_put in timer handlers instead of __in6_dev_put

It is possible for the timer handlers to run after the call to
ipv6_mc_down so use in6_dev_put instead of __in6_dev_put in the
handler function in order to do proper cleanup when the refcnt
reaches 0. Otherwise, the refcnt can reach zero without the
inet6_dev being destroyed and we end up leaking a reference to
the net_device and see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/mcast.c