]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: aquantia: fix wol configuration not applied sometimes
authorNikita Danilov <nikita.danilov@aquantia.com>
Tue, 4 Jun 2019 13:23:49 +0000 (13:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 00:39:43 +0000 (17:39 -0700)
commit930b9a0543385d4eb8ef887e88cf84d95a844577
treee37c42aead323997bb588b735f0e01eef561c9b4
parent0ee4e76937d69128a6a66861ba393ebdc2ffc8a2
net: aquantia: fix wol configuration not applied sometimes

WoL magic packet configuration sometimes does not work due to
couple of leakages found.

Mainly there was a regression introduced during readx_poll refactoring.

Next, fw request waiting time was too small. Sometimes that
caused sleep proxy config function to return with an error
and to skip WoL configuration.
At last, WoL data were passed to FW from not clean buffer.
That could cause FW to accept garbage as a random configuration data.

Fixes: 6a7f2277313b ("net: aquantia: replace AQ_HW_WAIT_FOR with readx_poll_timeout_atomic")
Signed-off-by: Nikita Danilov <nikita.danilov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c