]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
md: ensure md devices are freed before module is unloaded.
authorNeilBrown <neilb@suse.com>
Mon, 6 Feb 2017 02:41:39 +0000 (13:41 +1100)
committerShaohua Li <shli@fb.com>
Mon, 13 Feb 2017 17:17:53 +0000 (09:17 -0800)
commit9356863c9409efc79029c01a85d015efae977e69
tree985e9e3ca39ac84fa0ad866294e07cbd87874bb6
parent39b99586b321a9cbd4fe9abb5ea9346d2c4ca9c6
md: ensure md devices are freed before module is unloaded.

Commit: cbd199837750 ("md: Fix unfortunate interaction with evms")
change mddev_put() so that it would not destroy an md device while
->ctime was non-zero.

Unfortunately, we didn't make sure to clear ->ctime when unloading
the module, so it is possible for an md device to remain after
module unload.  An attempt to open such a device will trigger
an invalid memory reference in:
  get_gendisk -> kobj_lookup -> exact_lock -> get_disk

when tring to access disk->fops, which was in the module that has
been removed.

So ensure we clear ->ctime in md_exit(), and explain how that is useful,
as it isn't immediately obvious when looking at the code.

Fixes: cbd199837750 ("md: Fix unfortunate interaction with evms")
Tested-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/md.c