]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
sch_htb: Fix select_queue for non-offload mode
authorMaxim Mikityanskiy <maximmi@nvidia.com>
Thu, 11 Mar 2021 14:42:05 +0000 (16:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Mar 2021 02:30:32 +0000 (18:30 -0800)
commit93bde210c4341e79f0cd9cb160d889f4577e40b1
tree6d79a62ca47853b088e41d919a71b3489cf8f5c4
parent7a1468ba0e02eee24ae1353e8933793a27198e20
sch_htb: Fix select_queue for non-offload mode

htb_select_queue assumes it's always the offload mode, and it ends up in
calling ndo_setup_tc without any checks. It may lead to a NULL pointer
dereference if ndo_setup_tc is not implemented, or to an error returned
from the driver, which will prevent attaching qdiscs to HTB classes in
the non-offload mode.

This commit fixes the bug by adding the missing check to
htb_select_queue. In the non-offload mode it will return sch->dev_queue,
mimicking tc_modify_qdisc's behavior for the case where select_queue is
not implemented.

Reported-by: syzbot+b53a709f04722ca12a3c@syzkaller.appspotmail.com
Fixes: d03b195b5aa0 ("sch_htb: Hierarchical QoS hardware offload")
Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_htb.c