]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: dsa: felix: fix internal MDIO controller resource length
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 24 Feb 2023 15:52:34 +0000 (17:52 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Feb 2023 18:31:37 +0000 (18:31 +0000)
commit940af261321307cd1dd0fe8f9c34a6129f9d4bdc
tree9cf8c341e3e3013a1bcfc1230b7719add62750ab
parent0322ef49c1ac6f0e2ef37b146c0bf8440873072c
net: dsa: felix: fix internal MDIO controller resource length

The blamed commit did not properly convert the resource start/end format
into the DEFINE_RES_MEM_NAMED() start/length format, resulting in a
resource for vsc9959_imdio_res which is much longer than expected:

$ cat /proc/iomem
1f8000000-1f815ffff : pcie@1f0000000
  1f8140000-1f815ffff : 0000:00:00.5
    1f8148030-1f815006f : imdio

vs (correct)

$ cat /proc/iomem
1f8000000-1f815ffff : pcie@1f0000000
  1f8140000-1f815ffff : 0000:00:00.5
    1f8148030-1f814803f : imdio

Luckily it's not big enough to exceed the size of the parent resource
(pci_resource_end(pdev, VSC9959_IMDIO_PCI_BAR)), and it doesn't overlap
with anything else that the Linux driver uses currently, so the larger
than expected size isn't a practical problem that I can see. Although it
is clearly wrong in the /proc/iomem output.

Fixes: 044d447a801f ("net: dsa: felix: use DEFINE_RES_MEM_NAMED for resources")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/ocelot/felix_vsc9959.c